i had to make some changes to make it work properly with our review-board installation and put the results on the intarweb. it probably makes sense to send the changes i made upstream, but i'm waiting on doing that until the changes are put through their paces a bit more. i'd also like to add fetching various defaults from the config file or from svn props, such as the default review group.
the result is that i can now do this from the source tree:
post-review -p --summary='Add Containment contextActions() to widget conext menu', and get this as a result. this triggers a mail to the devel list as well notifying of the review request. neat-o!(the "-p" is for publish; one can also pass "-o" to open in a web browser after submission)
here's how other plasma devs can use this script to save time too:
- download it and make it executable
- optionally put it somewhere easy to get at (personally, i put it in /usr/local/bin)
- make sure you have the simplejson python module installed
- one click install for opensuse
- `apt-get install python-simplejson` for debianish systems
- create a ~/.reviewboardrc file that looks something like this:
TREES = {
'svn+ssh://aseigo@svn.kde.org/home/kde': {
'REVIEWBOARD_URL': 'http://matt.rogers.name',
'REVIEWBOARD_PATH': '/srv/kde/mirror'
}
}
replace the svn url with whatever you see in `svn info | grep Root`. (support for REVIEWBOARD_PATH is one of the changes i made to the script, btw.) - go into the source tree and start posting reviews with ease =) `post-review-plasma --help` has some useful information as well
update: using post-update some more i've come to appreciate how efficient `post-review-plasma -r #` is for updating the patch attached to a review.
3 comments:
Yes, it's OT, but I did not find a Plasma mailing list on a fast glimpse (kwin-mailinglist?).
It would be perfect if the search results in KickOff also show the location of that program.
E.g. search "Patie"
Result:
Kaptience
Games/Card Games
Maybe even with the correct Symbols scaled down before Games and Card Games.
That way you find yourself easier around in the new "menu" and the different ways distribution sort the kickoff-content imo.
If that is allready included/planned -- not in the OpenSuse-KDE 4.0 version I have -- then sorry.
I'm glad to see you guys using Review Board! :) I'm one of the project maintainers and a co-worker referred me to your post. I think I have some tricks that will make things easier in your setup.
First of all, rather than giving people a config file to use, just set the reviewboard:url property in the root of your SVN tree to your SVN server and commit it.
For example, your reviewboard:url property would be set to "http://matt.rogers.name/"
Second, I noticed your custom script had a default group of "plasma." Rather than needing to provide a separate script, you can go into your Review Board admin page, go to the "Default Reviewers" list and add an entry so that all changes modifying "/" or "/path/to/plasma" or whatever have a "plasma" group set by default. The path is a regular expression originating at the root of the repository specified.
I believe these covered the main things your custom script dealt with (though I may be wrong -- some things have changed recently in the script and I've been trying to sort out in a diff what your script modifies and what changes we put in).
Feel free to contact me if you have any other questions or ways we can help improve this process for you. You can also reach us at reviewboard@googlegroups.com.
just a note: the current reviewboard url is http://reviewboard.vidsolbach.de and the current path is svn://anonsvn.kde.org/home/kde/
Post a Comment