Thursday, November 29, 2007

konqi gets tab undo!

so one of those things that i've often wished konqi had has made it into svn thanks to Eduardo Robles Elvira (and dfaure for reviewing and helping with the patches along the way, of course). what is it speak of?

tab undo!

yep, close a tab, hit ctrl-z (or select undo from the menu if you're a slowmouser ;) and voila, it's back. since i tend to be a little tab close crazy at times, this is going to be an absolute godsend. it doesn't save form contents on web pages, but then there's the little dialog box to prevent that from happening; it does seem to do a great job of return to the right url though, be it a web, local file or other url. yay! =)

thanks Eduardo and David! konq is one of my favourite apps so it's great to see more hands in there improving things...

p.s. i also noticed that Eduardo made some change to konqi's profile handling. has someone caught the kde development bug? ;)

p.p.s. this make me all tingly inside

12 comments:

Jake said...

Oh good. I am all for more improvements in Konqueror, especially as I've been using it more. It's great, but I still sometimes miss features from Firefox extensions. :\

Schalken said...

Does that mean that Konqueror will also be able to undo the creation, duplication (which would be the same as closing the new tab) and detatchment of tabs?

Aaron J. Seigo said...

@schalken: creation: no; duplication: sort of. it doesn't get rid of the newly created window. you should ping Eduardo about those things =)

Eduardo Robles Elvira said...

I know this feature would be welcomed by konqi users :D

It actually saves form contents on web pages, but I'm still struggling to show the saved content. It also saves the history for each view, but it has a bug there too. Nothing very problematic, should be fixed soon.

Test this: enter a webpage with a form and fill it. now enter another webpage and close the tab. Hit Ctrl+Z. You get the closed tab. Maybe the hitory of the tab's view is hidden and you can't "go back", because of the history bug. So enter another webpage and suddently you will get the whole history. Now hit the "go back" button twice, and you will see that the first form content has been restored.
I know, a bit buggy, but getting better every day =)

About the konqueror profile, it's a fix to cleanup profiles, because now the they were getting a lot of history junk and in a profile you don't want to save the history of each view. That was noticed by David Faure and I fixed it =).

@schalken:
Now we're in feature freeze so we'll need to wait a bit for adding features. Anyway the idea is that we only undo things you have lost like.. closed tabs. Think of it as a "Recycle bin", though it can be discussed to see what's the behaviour we want to get.

But hell yeah! I plan to improve this feature: when you close a window, you will be able to undo that too =)

Also there are other things that konqi is need and if noone is planning adding I will, like modeless search, etc. Will see what future brings on!

Linus Berglund said...

I am not sure that "ctrl+z" is a good shortcut. i think it could actually be confusing if you are editing forms in different tabs and close a tab and continue editing forms in the other tabs.

it would be like the gimp restoring closed windows. the "ctrl+z" simply gets to "global"

KP said...

I agree with Linus, why not use ctrl+shift+t, as Firefox does?

Luis said...

Yeah Eduardo! University of Seville rules! This was one of the project competing in the 1st Free Software competition held there last year. I competed and won a second price :D

DanaKil said...

I really hope that Konqueror Userscript gets a boost one day :)
http://www.kde-apps.org/content/show.php?content=51482

(thanks to neofreko btw)

Anonymous said...

A nice feature.

I think it would be even nicer if it were like the way in Opera. Having a "waste bin" next to the tabs is very usfull imo and I miss that in Konqueror and Firefox a lot.

Anonymous said...

My thoughts as I read that:

1. "Why would you want that so much? It's pretty easy to just reopen the page."
2. "Oh actually that could be useful if you've filled in a form and accidentally closed it (those confirmation dialogs are annoying)."
3. "Oh. That sucks."

Anonymous said...

"It's pretty easy to just reopen the page."

No it's not. The tab can easily be days old, restored by session management, somewhere you got to by following lots of links or simply having a long complex URL.

turn_self_off said...

on topic of session management and recovery of tabs, will there come a way, like in firefox and opera, where you can close down konqueror, reopen it and have tabs restored?

i would guess the big issue here is profile related. as in, under what profile was one last operating (and given that each tab can have its own profile, not easy to answer).

still, i more often find myself using tabs when im browsing the web, and split windows/multiple windows when doing file management.

imo, dragging and dropping between tabs are ineffective vs dragging between splits...

maybe one should get a dialog when starting konqueror after having multiple tabs and/or splits active, asking if one want to restore last state, or select a clean profile?